-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Spanner): Support FGAC #5642
Conversation
79098dc
to
50ea8d3
Compare
ba0e807
to
51b4377
Compare
51b4377
to
613dc32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls fix the formatting, docblocks and test changes requested.
In my local env, php8.1, for pre-existing tests parsing
creator_role is null . Do you think we should add array_filter over here: google-cloud-php/Spanner/src/Operation.php Lines 564 to 567 in 50f0759
|
Changes looks good to me now, thanks for diligently resolve all comments. |
1723558
to
51922a6
Compare
51922a6
to
0ae470b
Compare
0ae470b
to
42a2df3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR add the FGAC support for PHP Spanner library.
The FGAC integration tests are skipped in the emulator since it has not yet implemented the FGAC support.
Other languages also skips the same. Ref: https://github.com/googleapis/google-cloud-ruby/pull/19067/files#diff-3bf69404604fe1c87333533412f6e24d5867aab51a726e98843ebd63cd39b3a5R28