[Spanner] CacheSessionPool::clear() does not work in some situations

[taka-oyama]

We noticed that running Google\Cloud\Spanner\Session\CacheSessionPool::clear() does not work if the process terminates right after calling the method.

I have prepared a sample code to replicate the issue.

Environment details

• OS: Alpine Linux 3.16
• PHP version: 8.0.20
• Package name and version: google/cloud-spanner v1.53.0

Steps to reproduce

1. git checkout [email protected]:taka-oyama/google-cloud-php-test.git
2. git checkout test/spanner-session-clear
3. Rename .env.sample to .env and configure it to match your setup.
4. Run docker-compose build && docker-compose run app -> this will start a bash session inside the container.
5. Run php session_create.php to create the sessions.
6. Confirm session by running php session_check.php
7. Attempt to clear session by running php session_clear.php
8. Confirm that session is not cleared by doing step 5 again.
9. Open session_clear.php and uncomment the last line.
10. Repeat steps 7 and 8 to confirm that session is cleared.

I assume this is happening because of the code below.

google-cloud-php/Spanner/src/Session/CacheSessionPool.php

Lines 821 to 825 in e8e67bd

	$this->deleteCalls[] = $this->database->connection()
	->deleteSessionAsync([
	'name' => $session['name'],
	'database' => $this->database->name()
	]);

It's deleting the session asynchronously but doesn't actually wait for it to end which is probably getting cancelled when the script reaches the end.

[vishwarajanand]

Hi @taka-oyama thanks for raising this issue so I cannot find taka-oyama/google-cloud-php-test nor the scripts session_[create|check|clear].php.

I need inputs to repro this behavior.

[taka-oyama]

Sorry, I had the repo set to private.
I changed it to public so it should be visible now.

[vishwarajanand]

Thanks for making the repro scripts public, they were helpful for my testing. Fix underway.

[vishwarajanand]

Now, this should be fixed.