-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support for PHPUnit 8 #5252
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
changed the title
[DO NOT MERGE]: Add support for PHP 8 tests
chore: add support for PHP 8 tests
May 5, 2022
bshaffer
changed the title
chore: add support for PHP 8 tests
chore: add support for PHPUnit 8
May 5, 2022
bshaffer
commented
May 5, 2022
composer update --prefer-dist --no-interaction --no-suggest -d Bigtable/ | ||
composer config minimum-stability dev -d Bigtable/ | ||
composer config repositories.local path "../Core" -d Bigtable | ||
composer require "google/cloud-core:*" -d Bigtable/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These additional lines make sure that the tests run the emulator using the current branch for the google/cloud-core
dependency, instead of using a tagged version. This is required for this PR because we made changes in Core that these tests need to pass.
dwsupplee
suggested changes
May 12, 2022
dwsupplee
approved these changes
May 13, 2022
This was referenced May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds PHPUnit 8 for testing!!
This will allow us to test on PHP 8.0 and 8.1.
Some important notes:
phpunit-prophecy
, and there is no polyfill available for that yet.composer.json
to keep compatibility with PHPUnit 4 and 5.ResultPrinter
class we were using for snippets test. This was causing function signature conflicts between PHPUnit versions, and it didn't seem worth the headache to make it compatible (which is non-trivial).