fix: Improve PHP 8.1 compatibility by disabling deprecation notices #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromegamez
force-pushed
the
class-hierarchy-checks-php-8-1
branch
from
134d255 to
21e9f6a
Compare
jeromegamez
force-pushed
the
class-hierarchy-checks-php-8-1
branch
from
21e9f6a to
eb24e54
Compare
jeromegamez
force-pushed
the
class-hierarchy-checks-php-8-1
branch
from
eb24e54 to
353a2b3
Compare
bshaffer
approved these changes
Apr 20, 2022
dwsupplee
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4554
I honestly have no idea how to reliably test this, but what I did was open the project in PHPStorm, set the language level to PHP 8.1, and run the Class Hierarchy Checks inspection.
See https://php.watch/versions/8.1/internal-method-return-types#ReturnTypeWillChange
PS: This will probably not survive PHP 8.2 😅