Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BigQuery Parameterization #246

Closed
omaray opened this issue Nov 21, 2016 · 6 comments
Closed

Implement BigQuery Parameterization #246

omaray opened this issue Nov 21, 2016 · 6 comments
Assignees
@dwsupplee
Labels
api: bigquery Issues related to the BigQuery API. release blocking Required feature/issue must be fixed prior to next release. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@omaray
Copy link
Contributor

omaray commented Nov 21, 2016

https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs/query#request-body

A query can put placeholders in the query text, which can then be filled in with queryParameters. Depending on what parameterMode is set to, the parameter can be positional ? or names @somename.

See also: googleapis/google-cloud-python#2551
@omaray omaray added api: bigquery Issues related to the BigQuery API. release blocking Required feature/issue must be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. triage labels Nov 21, 2016
@danoscarmike
Copy link
Contributor

@dwsupplee do you have anything blocking this? If so, please let me know. If you are actively working can you give me an estimate to completion? Thanks!

@dwsupplee
Copy link
Contributor

Hey @danoscarmike, no blockers and the estimated completion is by tomorrow.

@bshaffer bshaffer mentioned this issue Nov 30, 2016
Closed
@danoscarmike
Copy link
Contributor

@dwsupplee any update? Can you link PR when ready? Thanks!

@dwsupplee
Copy link
Contributor

@danoscarmike just wanted to provide a quick update. I ran into a few snags with making sure we support the various standard SQL types that held things up a little bit. Have a good gameplan now and the new ETA is this weekend.

@dwsupplee
Copy link
Contributor

Ha! Looks like we were on each other's minds :)

@danoscarmike
Copy link
Contributor

Thanks David!

@dwsupplee dwsupplee mentioned this issue Dec 5, 2016
Merged
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwsupplee dwsupplee

Labels
api: bigquery Issues related to the BigQuery API. release blocking Required feature/issue must be fixed prior to next release. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dwsupplee @danoscarmike @omaray @yoshi-automation