Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SymfonyLockAdapter throws Exception with wrong information #1199

Closed
taka-oyama opened this issue Jul 31, 2018 · 1 comment
Closed

SymfonyLockAdapter throws Exception with wrong information #1199

taka-oyama opened this issue Jul 31, 2018 · 1 comment
Assignees
Labels
api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@taka-oyama
Copy link
Contributor

Please see

https://github.com/GoogleCloudPlatform/google-cloud-php/blob/master/Core/src/Lock/SymfonyLockAdapter.php#L63

The code block for catching and throwing the error looks like below

throw new \RuntimeException($ex->getMessage());

This tells me almost nothing about the actual exception that was thrown.

Is there a reason why it's handled this way?

@taka-oyama taka-oyama changed the title SymfonyLockAdapter throws Exception with useless information SymfonyLockAdapter throws Exception with wrong information Jul 31, 2018
@dwsupplee dwsupplee added api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 31, 2018
@dwsupplee
Copy link
Contributor

There's no good reason we can't add more detail to the exception here, we'll get that fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants