pubsub: unacked messages being redelivered #2756
Assignees
Comments
|
I've managed to reproduce the duplicated delivery which happens probably 2/5 times: const PubSub = require('@google-cloud/pubsub')
const pubsub = new PubSub(/*{
projectId: '',
keyFilename: ''
} */)
function log(...args) {
console.log(`[${new Date().toISOString()}]`, ...args)
}
function errLog(...args) {
console.error(`[${new Date().toISOString()}]`, ...args)
}
const name = 'com.test.domain-redelivery-sub'
log(`Creating pubsub for ${name}`)
const subOptions = {
flowControl: {
maxMessages: 3
},
// Max deadline: https://cloud.google.com/pubsub/docs/reference/rest/v1/projects.subscriptions/create
ackDeadlineSeconds: 30
}
function handleMessage(m) {
log(`Received message: ${m.id} / ${m.publishTime}: `, m.data.toString())
const shouldAck = true
const waiting = 600 * 1000
log(`Waiting ${waiting / 1000}s to reply with ${shouldAck ? 'ACK' : 'NACK'}`)
setTimeout(() => {
log(`Reporting message: ${m.id} - ${shouldAck ? 'ACK' : 'NACK'}`)
if (shouldAck) {
m.ack()
} else {
m.nack()
}
}, waiting)
}
function handleError(err) {
errLog(`Error with subscription ${name}:`, err)
throw err
}
pubsub.topic(name).get({ autoCreate: true }, (topicErr, topic) => {
if (topicErr) {
errLog(`Failed to create topic - ${name}:`, topicErr)
throw topicErr
}
topic.createSubscription(`${name}-subscription`, subOptions, (subErr, sub) => {
if (subErr) return handleError(subErr)
sub.on('message', handleMessage)
sub.on('error', handleError)
log(`Subscribed to ${name} with subscription ID: ${sub.name}`)
const sendMessage = () => {
const m = `Message @ ${new Date().toString()}`
log('Sending message:', m)
topic.publisher().publish(Buffer.from(m), mErr => {
if (mErr) return errLog('Error publishing:', mErr)
})
}
setTimeout(sendMessage, 4 * 1000)
})
})Console: Pubsub version: 0.14.8 (I shall try 0.15 but I'm not sure it'll make a difference as it was only GAX that was updated?) Also - I let the code run for a while after the initial message was ACKed - and you can see it was still redelivered then. |
rhodgkins
changed the title
rhodgkins
changed the title
rhodgkins
changed the title
|
This issue was moved to googleapis/nodejs-pubsub#2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In previous (I think v0.12 and lower) versions of pubsub messages were auto acked upon receiving a message (or if this was turned off, had to be manually acked). As I understood this had to happen within the
ackDeadlineSecondstime and this could be modified withsubscription.modifyAckDeadline().Now the newer version (v0.15), from looking at the code, uses timers to "lease" out the message (using the
acDeadlineSecondstime as the initial lease interval), automatically extending the ack deadline until eithermessage.ack()ormessage.nack()is called?What happens if you don't do this for a long period of time? Does the lease timer keep on and on extending the ack deadline?
The reason I'm asking for clarification is that I've seen unacked (that is neither
.ack()or.nack()has been called on the message) messages being delivered again after a period of time.So the following would happen:
I've also had it where I've nacked a message and the current message I'm processing is delivered again.
I'll try and post some replication steps for the latter issue (its not consistent when I have seen it), but if anyone can confirm by above questions that would be great! Cheers!
The text was updated successfully, but these errors were encountered: