From 5e63c65dfcc4cc5302d759b623e4dbff3e189a46 Mon Sep 17 00:00:00 2001 From: Andrea Lin Date: Thu, 6 Sep 2018 14:23:43 -0700 Subject: [PATCH 1/3] javadoc fixes for BigtableInstanceAdminClient --- .../admin/v2/BigtableInstanceAdminClient.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java b/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java index 24b8bfc5f8ef..c0a6801c84e1 100644 --- a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java +++ b/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java @@ -921,13 +921,13 @@ public AppProfile updateAppProfile(UpdateAppProfileRequest request) { * *
{@code
    *
-   * ApiFuture existingAppProfileFuture = client.getAppProfileAsync("my-instance", "my-app-profile");
+   * ApiFuture\ existingAppProfileFuture = client.getAppProfileAsync("my-instance", "my-app-profile");
    *
-   * ApiFuture updatedAppProfileFuture = ApiFutures.transformAsync(
+   * ApiFuture\ updatedAppProfileFuture = ApiFutures.transformAsync(
    *   existingAppProfileFuture,
-   *   new ApiAsyncFunction() {
-   *     @Override
-   *     public ApiFuture apply(AppProfile existingAppProfile) {
+   *   new ApiAsyncFunction\() {
+   *     \@Override
+   *     public ApiFuture\ apply(AppProfile existingAppProfile) {
    *       return client.updateAppProfileAsync(
    *         UpdateAppProfileRequest.of(existingAppProfile)
    *           .setRoutingPolicy(SingleClusterRoutingPolicy.of("my-other-cluster"))
@@ -937,7 +937,7 @@ public AppProfile updateAppProfile(UpdateAppProfileRequest request) {
    *   MoreExecutors.directExecutor()
    * );
    *
-   * ApiFuture appProfile = updatedAppProfileFuture.get();
+   * ApiFuture\ appProfile = updatedAppProfileFuture.get();
    * }
* * @see UpdateAppProfileRequest From 52d5d6161fb04450dd644549fbf31d6c8ae5c5bc Mon Sep 17 00:00:00 2001 From: Andrea Lin Date: Thu, 6 Sep 2018 15:06:55 -0700 Subject: [PATCH 2/3] use instead of @code --- .../admin/v2/BigtableInstanceAdminClient.java | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java b/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java index c0a6801c84e1..bd836863b957 100644 --- a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java +++ b/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java @@ -919,15 +919,14 @@ public AppProfile updateAppProfile(UpdateAppProfileRequest request) { * *

Sample code: * - *

{@code
+   * 

    *
-   * ApiFuture\ existingAppProfileFuture = client.getAppProfileAsync("my-instance", "my-app-profile");
+   * ApiFuture existingAppProfileFuture = client.getAppProfileAsync("my-instance", "my-app-profile");
    *
-   * ApiFuture\ updatedAppProfileFuture = ApiFutures.transformAsync(
+   * ApiFuture updatedAppProfileFuture = ApiFutures.transformAsync(
    *   existingAppProfileFuture,
-   *   new ApiAsyncFunction\() {
-   *     \@Override
-   *     public ApiFuture\ apply(AppProfile existingAppProfile) {
+   *   new ApiAsyncFunction() {
+   *     public ApiFuture apply(AppProfile existingAppProfile) {
    *       return client.updateAppProfileAsync(
    *         UpdateAppProfileRequest.of(existingAppProfile)
    *           .setRoutingPolicy(SingleClusterRoutingPolicy.of("my-other-cluster"))
@@ -937,8 +936,8 @@ public AppProfile updateAppProfile(UpdateAppProfileRequest request) {
    *   MoreExecutors.directExecutor()
    * );
    *
-   * ApiFuture\ appProfile = updatedAppProfileFuture.get();
-   * }
+ * ApiFuture appProfile = updatedAppProfileFuture.get(); + * }
* * @see UpdateAppProfileRequest */ From dc89304dfc2f4373232a5a77b0916401e77814a8 Mon Sep 17 00:00:00 2001 From: Andrea Lin Date: Thu, 6 Sep 2018 15:38:29 -0700 Subject: [PATCH 3/3] use code@ --- .../cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java b/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java index bd836863b957..3cb16b00ef9d 100644 --- a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java +++ b/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java @@ -919,7 +919,7 @@ public AppProfile updateAppProfile(UpdateAppProfileRequest request) { * *

Sample code: * - *


+   * 
{@code
    *
    * ApiFuture existingAppProfileFuture = client.getAppProfileAsync("my-instance", "my-app-profile");
    *
@@ -937,7 +937,7 @@ public AppProfile updateAppProfile(UpdateAppProfileRequest request) {
    * );
    *
    * ApiFuture appProfile = updatedAppProfileFuture.get();
-   * }
+ * }
* * @see UpdateAppProfileRequest */