From f2dc019ebc193c5af9e7ed3b7e2030bc97faf1ef Mon Sep 17 00:00:00 2001 From: Ajay Kannan Date: Wed, 28 Oct 2015 10:31:48 -0700 Subject: [PATCH] Remove todos from core and datastore --- .../src/main/java/com/google/gcloud/ServiceOptions.java | 2 -- .../main/java/com/google/gcloud/datastore/DatastoreOptions.java | 2 -- .../test/java/com/google/gcloud/datastore/DatastoreTest.java | 1 - 3 files changed, 5 deletions(-) diff --git a/gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java b/gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java index 8555b8d61ed4..c58a71c8b7ef 100644 --- a/gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java +++ b/gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java @@ -411,8 +411,6 @@ private static boolean isWindows() { } protected static String getAppEngineProjectId() { - // TODO(ozarov): An alternative to reflection would be to depend on AE api jar: - // http://mvnrepository.com/artifact/com.google.appengine/appengine-api-1.0-sdk/1.2.0 try { Class factoryClass = Class.forName("com.google.appengine.api.appidentity.AppIdentityServiceFactory"); diff --git a/gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/DatastoreOptions.java b/gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/DatastoreOptions.java index 328573ac7164..5338c03a6d56 100644 --- a/gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/DatastoreOptions.java +++ b/gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/DatastoreOptions.java @@ -172,8 +172,6 @@ public String namespace() { } private static String defaultNamespace() { - // TODO(ozarov): An alternative to reflection would be to depend on AE api jar: - // http://mvnrepository.com/artifact/com.google.appengine/appengine-api-1.0-sdk/1.2.0 try { Class clazz = Class.forName("com.google.appengine.api.NamespaceManager"); Method method = clazz.getMethod("get"); diff --git a/gcloud-java-datastore/src/test/java/com/google/gcloud/datastore/DatastoreTest.java b/gcloud-java-datastore/src/test/java/com/google/gcloud/datastore/DatastoreTest.java index 1d2bb4889658..f639ca3fdac0 100644 --- a/gcloud-java-datastore/src/test/java/com/google/gcloud/datastore/DatastoreTest.java +++ b/gcloud-java-datastore/src/test/java/com/google/gcloud/datastore/DatastoreTest.java @@ -459,7 +459,6 @@ public void testRunStructuredQuery() { assertEquals("Dan", entity.getString("name")); assertEquals(2, entity.properties().size()); assertFalse(results4.hasNext()); - // TODO(ozarov): construct a test to verify nextQuery/pagination } @Test