Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT Failure(google-cloud-compute): ITPaginationTest.testPaginationIterating zone not found #9134

Open
emmileaf opened this issue Feb 17, 2023 · 5 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@emmileaf
Copy link
Contributor

emmileaf commented Feb 17, 2023

Failures observed in GraalVM nightly build and presubmit. This error is happening often (in a number of presubmits and re-triggers), but not consistently:

Problematic test - com.google.cloud.compute.v1.integration.ITPaginationTest.testPaginationIterating

Failures (1):
  JUnit Vintage:ITPaginationTest:testPaginationIterating
    MethodSource [className = 'com.google.cloud.compute.v1.integration.ITPaginationTest', methodName = 'testPaginationIterating', methodParameterTypes = '']
    => java.lang.AssertionError: Zone us-central1-a was not found for cloud-java-ci-test in zones list (size: 65).
       org.junit.Assert.fail(Assert.java:89)
       org.junit.Assert.assertTrue(Assert.java:42)
       com.google.cloud.compute.v1.integration.ITPaginationTest.testPaginationIterating(ITPaginationTest.java:124)
       [email protected]/java.lang.reflect.Method.invoke(Method.java:568)
       org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
       org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
       org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
       org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
       org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
       org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
       [...]

This could be a similar issue with interfering compute resources from integration tests as observed/addressed in #8260.

@emmileaf emmileaf added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 17, 2023
@emmileaf
Copy link
Contributor Author

Update - seems like this is a previously observed flake coming back: googleapis/java-compute#683, googleapis/java-compute#682 (comment) look relevant.

@emmileaf
Copy link
Contributor Author

An initial investigation from locally reproducing this error w/ Terraform:

gcloud compute zones list returns 119 zones, which also consistent with the response.iterateAll() size from testList().

In testPaginationIterating(), iterating over zones sometimes gets stuck at around this point:

...
Zone: europe-west9-b
Zone: europe-west9-a
Zone: me-central1-b
Zone: me-central1-c

response.IterateAll() size: 46

And sometimes able to get a full list including us-central1-a (DEFAULT_ZONE):

...
Zone: europe-west9-b
Zone: europe-west9-a
Zone: me-west1-a
Zone: me-west1-c
Zone: me-west1-b
...
Zone: us-central1-a
...

@emmileaf
Copy link
Contributor Author

The nightly builds are back to green, and I am no longer able to reproduce this error 🤔. Leaving this issue open to track and revisit if it resurfaces again.

@lqiu96
Copy link
Contributor

lqiu96 commented Apr 25, 2023

Closing this issue now. It's been ~3 months since this last flaked. We can re-open if this test flakes again.

@lqiu96 lqiu96 closed this as completed Apr 25, 2023
@emmileaf
Copy link
Contributor Author

emmileaf commented Jun 9, 2023

Observed this flake again in nightly build - reopening to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

3 participants
@lqiu96 @emmileaf and others