Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [maps-routing] new module for maps-routing #8811

Merged
merged 6 commits into from
Nov 21, 2022
Merged

feat: [maps-routing] new module for maps-routing #8811

merged 6 commits into from
Nov 21, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Nov 17, 2022

No description provided.

meltsufin
meltsufin reviewed Nov 17, 2022
View reviewed changes
versions.txt
@@ -586,3 +586,6 @@ grpc-google-cloud-workflows-v1:2.6.0:2.6.0
proto-google-cloud-workflows-v1beta:0.12.0:0.12.0
proto-google-cloud-workflows-v1:2.6.0:2.6.0
google-cloud-dns:2.4.0:2.4.0
google-maps-routing:0.0.0:0.0.1-SNAPSHOT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the versions above also be -SNAPSHOT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I'm merging Release Please's snapshot pull request #8794 first.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged. The lines above have "-SNAPSHOT" now.

@suztomo
Copy link
Member Author

suztomo commented Nov 18, 2022 •
edited
Loading 

diff --git a/java-maps-routing/google-maps-routing-bom/pom.xml b/java-maps-routing/google-maps-routing-bom/pom.xml
index 198cc242..b[5](https://github.com/googleapis/google-cloud-java/actions/runs/3500494769/jobs/5863222771#step:5:6)01870d 100[6](https://github.com/googleapis/google-cloud-java/actions/runs/3500494769/jobs/5863222771#step:5:7)44
--- a/java-maps-routing/google-maps-routing-bom/pom.xml
+++ b/java-maps-routing/google-maps-routing-bom/pom.xml
@@ -9,[7](https://github.com/googleapis/google-cloud-java/actions/runs/3500494769/jobs/5863222771#step:5:8) +9,7 @@
   <parent>
     <groupId>com.google.cloud</groupId>
     <artifactId>google-cloud-pom-parent</artifactId>
-    <version>0.3.0</version><!-- {x-version-update:google-cloud-pom-parent:current} -->
+    <version>0.4.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-pom-parent:current} -->
     <relativePath>../../google-cloud-pom-parent/pom.xml</relativePath>
   </parent>
 
diff --git a/java-maps-routing/pom.xml b/java-maps-routing/pom.xml
index c375eefa..2ea54[8](https://github.com/googleapis/google-cloud-java/actions/runs/3500494769/jobs/5863222771#step:5:9)e4 100644
--- a/java-maps-routing/pom.xml
+++ b/java-maps-routing/pom.xml
@@ -13,7 +13,7 @@
   <parent>
     <groupId>com.google.cloud</groupId>
     <artifactId>google-cloud-jar-parent</artifactId>
-    <version>0.3.0</version><!-- {x-version-update:google-cloud-jar-parent:current} -->
+    <version>0.4.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-jar-parent:current} -->
     <relativePath>../google-cloud-jar-parent/pom.xml</relativePath>
   </parent>

Needs more edits.

@suztomo
Copy link
Member Author

suztomo commented Nov 21, 2022

Generation diff succeeded.

Screen Shot 2022-11-21 at 9 33 42 AM

@suztomo suztomo requested a review from meltsufin November 21, 2022 14:33
@suztomo
Copy link
Member Author

suztomo commented Nov 21, 2022

@meltsufin PTAL.

@suztomo suztomo merged commit 2bf8d50 into main Nov 21, 2022
@suztomo suztomo deleted the new_module_java-maps-routing branch November 21, 2022 15:23
@release-please release-please bot mentioned this pull request Nov 21, 2022
Merged
alicejli pushed a commit that referenced this pull request Nov 28, 2022
@suztomo @gcf-owl-bot @alicejli
feat: [maps-routing] new module for maps-routing (#8811)
c1233f4 
* feat: [maps-routing] new module for maps-routing

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* parent versions

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suztomo @meltsufin