Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [eventarc] Add CMEK support to Eventarc client library #8731

Merged
merged 4 commits into from
Nov 16, 2022
Merged

feat: [eventarc] Add CMEK support to Eventarc client library #8731

merged 4 commits into from
Nov 16, 2022

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Nov 4, 2022 •
edited by diegomarquezp
Loading

  • Regenerate this pull request now.

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 4, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2022
@snippet-bot
Copy link

snippet-bot bot commented Nov 4, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 18 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 4, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 4, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 4, 2022
@alicejli alicejli added the automerge Merge the pull request once unit tests and other checks pass. label Nov 8, 2022
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Nov 8, 2022

Owl bot is regenerating pull request 8731...
Build name: YWIzYmQ1YWEtNjY5Ni00ZWUxLTk1MmQtZjNjYjM4MzNhZDc5

@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-java-eventarc branch from 9a6bff2 to bb32873 Compare November 8, 2022 16:19
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 8, 2022
@alicejli alicejli added the automerge Merge the pull request once unit tests and other checks pass. label Nov 9, 2022
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Nov 9, 2022

Owl bot is regenerating pull request 8731...
Build name: NDM3NDJiNDAtYjVlZi00NDQwLTgyMDItOTZmZjViZjlhY2Iz

@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-java-eventarc branch from b6f7b89 to 4a4693a Compare November 9, 2022 15:59
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 10, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 10, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2022
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Nov 16, 2022

Owl bot is regenerating pull request 8731...
Build name: MGQ2ODliOGYtOTcxYi00MzZkLWFjZWYtODdiYjQ1YmIxMTBi

@suztomo
Copy link
Member

suztomo commented Nov 16, 2022

Now the postprocessor is updated #8801. Checked "Regenerate" this pull request.

@gcf-owl-bot
feat: Add CMEK support to Eventarc client library
fc4ef71 
The client library users will now be able to manipulate the CMEK in Eventarc.
For more information check here: https://cloud.google.com/eventarc/docs/use-cmek

feat: Update Eventarc Channel to support custom events

This change unlocks the custom eventing in Eventarc.

PiperOrigin-RevId: 486209405

Source-Link: googleapis/googleapis@4733d74

Source-Link: https://github.com/googleapis/googleapis-gen/commit/68267fca6f0cb3e8c69161f7b451f29564843e61
Copy-Tag: eyJwIjoiamF2YS1ldmVudGFyYy8uT3dsQm90LnlhbWwiLCJoIjoiNjgyNjdmY2E2ZjBjYjNlOGM2OTE2MWY3YjQ1MWYyOTU2NDg0M2U2MSJ9
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-java-eventarc branch from 5f4aba7 to fc4ef71 Compare November 16, 2022 16:12
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@suztomo
Copy link
Member

suztomo commented Nov 16, 2022 •
edited
Loading

Now we no longer observe the problem of "0.0.1-SNAPSHOT" version googleapis/synthtool#1707

CC: @alicejli

@suztomo
Copy link
Member

suztomo commented Nov 16, 2022 

2022-11-16T16:39:21.3839533Z [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-eventarc/google-cloud-eventarc/src/main/java/com/google/cloud/eventarc/v1/stub/GrpcEventarcStub.java:[1001,51] cannot find symbol
2022-11-16T16:39:21.3839683Z [ERROR]   symbol:   class TestIamPermissionsResponse
2022-11-16T16:39:21.3839893Z [ERROR]   location: class com.google.cloud.eventarc.v1.stub.GrpcEventarcStub
2022-11-16T16:39:21.3840483Z [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-eventarc/google-cloud-eventarc/src/main/java/com/google/cloud/eventarc/v1/stub/HttpJsonEventarcStub.java:[72,25] package com.google.iam.v1 does not exist
2022-11-16T16:39:21.3841078Z [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-eventarc/google-cloud-eventarc/src/main/java/com/google/cloud/eventarc/v1/stub/HttpJsonEventarcStub.java:[73,25] package com.google.iam.v1 does not exist
2022-11-16T16:39:21.3841666Z [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-eventarc/google-cloud-eventarc/src/main/java/com/google/cloud/eventarc/v1/stub/HttpJsonEventarcStub.java:[74,25] package com.google.iam.v1 does not exist

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Nov 16, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7e32e27 into main Nov 16, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-copy-java-eventarc branch November 16, 2022 21:02
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 16, 2022
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Nov 16, 2022

Owl bot is regenerating pull request 8731...
Build name: MmEzZWRmMjAtNThmYy00NTFkLWIxZTEtNjcxZWZhODljMGY0

alicejli pushed a commit that referenced this pull request Nov 17, 2022
@gcf-owl-bot @alicejli
feat: [eventarc] Add CMEK support to Eventarc client library (#8731)
afb0993 
- [ ] Regenerate this pull request now.

The client library users will now be able to manipulate the CMEK in Eventarc.
For more information check here: https://cloud.google.com/eventarc/docs/use-cmek

feat: Update Eventarc Channel to support custom events

This change unlocks the custom eventing in Eventarc.

PiperOrigin-RevId: 486209405

Source-Link: https://togithub.com/googleapis/googleapis/commit/4733d7473771f2c32bfe08f7025074617b33dc90

Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/68267fca6f0cb3e8c69161f7b451f29564843e61
Copy-Tag: eyJwIjoiamF2YS1ldmVudGFyYy8uT3dsQm90LnlhbWwiLCJoIjoiNjgyNjdmY2E2ZjBjYjNlOGM2OTE2MWY3YjQ1MWYyOTU2NDg0M2U2MSJ9
@release-please release-please bot mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicejli alicejli alicejli approved these changes

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
owl-bot-copy owlbot:run Add this label to trigger the Owlbot post processor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suztomo @alicejli @yoshi-kokoro