Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OwlBot postprocessor adds gitignore back #8683

Closed
suztomo opened this issue Oct 25, 2022 · 2 comments · Fixed by googleapis/synthtool#1672
Closed

OwlBot postprocessor adds gitignore back #8683

suztomo opened this issue Oct 25, 2022 · 2 comments · Fixed by googleapis/synthtool#1672
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Oct 25, 2022

#8682 (comment)

Somehow owlbot-java is trying to add the ".gitignore" file even though the file is excluded in owlbot.py https://github.com/googleapis/google-cloud-java/blob/main/java-dialogflow/owlbot.py#L106

@suztomo suztomo added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 25, 2022
@lqiu96
Copy link
Contributor

lqiu96 commented Oct 27, 2022

Took a look at the owlbot and I'm guessing it's due to this line: https://github.com/googleapis/synthtool/blob/48f8857c642792150e2474418b1dbf545c162f8d/docker/owlbot/java/bin/write_templates.sh#L21 called from the entrypoint.sh https://github.com/googleapis/synthtool/blob/48f8857c642792150e2474418b1dbf545c162f8d/docker/owlbot/java/bin/entrypoint.sh#L22

It's before owlbot.py is called so it would have already been included (making the exclusion useless).

I'm guessing we don't need to copy the template/gitignore file over (at least for the monorepo). Tomo can confirm if this is actually the case.

@lqiu96
Copy link
Contributor

lqiu96 commented Oct 27, 2022

Looks like dialogflow's .gitignore was added back in: https://github.com/googleapis/google-cloud-java/blob/97a095884b05d093ff52feadb8cf9cc0a7a9e3cb/java-dialogflow/.gitignore

Once @suztomo's PR gets merged we should probably re-run the script for deleting the .gitignore for all modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants