Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenovateBot unexpectedly modifies values set by Release Please #8239

Closed
suztomo opened this issue Aug 30, 2022 · 4 comments
Closed

RenovateBot unexpectedly modifies values set by Release Please #8239

suztomo opened this issue Aug 30, 2022 · 4 comments
Assignees
@ddixit14
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Aug 30, 2022 •
edited
Loading

Example #8237

image

It causes conflicts in pull requests (#8340):

Screen Shot 2022-09-16 at 9 52 29 AM

@ddixit14 Would you evaluate whether this is a problem or not?
@suztomo suztomo added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 30, 2022
@suztomo suztomo assigned suztomo and ddixit14 and unassigned suztomo Aug 30, 2022
@ddixit14
Copy link
Contributor

ddixit14 commented Sep 12, 2022 •
edited
Loading

@suztomo I think this is because these artifacts have already been released on maven central, and renovate bot is just updating them with the latest version. And this process is messing up with release-please attempt to update the versions on release. This is mainly due to the lag google-cloud-java has in doing a release for the artifact (because we are not releasing in shadow mode). Once we start releasing from monorepo, such conflicts should not occur (hope so). What do you think?

@suztomo
Copy link
Member Author

suztomo commented Sep 13, 2022

@ddixit14 That's good reasoning. But if RenovateBot is making conflicts in this repository and our versions become inconsistent as per Release Please, we cannot start releasing artifacts from this repository.

Can you configure renovate.json to limit the scope of RenovateBot into only java-shared-config and java-shared-dependencies?

@suztomo
Copy link
Member Author

suztomo commented Sep 15, 2022

@ddixit14 As discussed, there should be RenovateBot's option to enable "create pull requests only when corresponding item is checked in Dependency Dashboard". Find the option.

If you don't find option and taking 30 mins or more, I'll search it.

@suztomo suztomo mentioned this issue Sep 16, 2022
Merged
@suztomo suztomo closed this as completed Sep 23, 2022
@suztomo
Copy link
Member Author

suztomo commented Sep 23, 2022

Now we have #7649

@suztomo suztomo mentioned this issue Oct 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddixit14 ddixit14

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@suztomo @ddixit14