Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings showing up in build logs #5287

Closed
elharo opened this issue May 23, 2019 · 3 comments · Fixed by #5786
Closed

Deprecation warnings showing up in build logs #5287

elharo opened this issue May 23, 2019 · 3 comments · Fixed by #5786
Assignees
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@elharo
Copy link
Contributor

elharo commented May 23, 2019

[WARNING] /usr/local/google/home/elharo/google-cloud-java/google-cloud-clients/google-cloud-logging/src/main/java/com/google/cloud/logging/SinkInfo.java:[586,13] setOutputVersionFormat(com.google.logging.v2.LogSink.VersionFormat) in com.google.logging.v2.LogSink.Builder has been deprecated
[WARNING] /usr/local/google/home/elharo/google-cloud-java/google-cloud-clients/google-cloud-logging/src/main/java/com/google/cloud/logging/SinkInfo.java:[599,58] getOutputVersionFormat() in com.google.logging.v2.LogSink has been deprecated
[WARNING] /usr/local/google/home/elharo/google-cloud-java/google-cloud-clients/google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java:[138,22] <V,X>transform(com.google.api.core.ApiFuture<? extends V>,com.google.api.core.ApiFunction<? super V,? extends X>) in com.google.api.core.ApiFutures has been deprecated
[WARNING] /usr/local/google/home/elharo/google-cloud-java/google-cloud-clients/google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java:[597,19] <V>addCallback(com.google.api.core.ApiFuture<V>,com.google.api.core.ApiFutureCallback<? super V>) in com.google.api.core.ApiFutures has been deprecated
[WARNING] /usr/local/google/home/elharo/google-cloud-java/google-cloud-clients/google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java:[632,12] addProjectIds(java.lang.String) in com.google.logging.v2.ListLogEntriesRequest.Builder has been deprecated
[WARNING] /usr/local/google/home/elharo/google-cloud-java/google-cloud-clients/google-cloud-logging/src/main/java/com/google/cloud/logging/spi/v2/GrpcLoggingRpc.java:[99,17] usePlaintext(boolean) in io.grpc.ManagedChannelBuilder has been deprecated
[WARNING] /usr/local/google/home/elharo/google-cloud-java/google-cloud-clients/google-cloud-logging/src/main/java/com/google/cloud/logging/spi/v2/GrpcLoggingRpc.java:[181,22] <V,X>catching(com.google.api.core.ApiFuture<? extends V>,java.lang.Class<X>,com.google.api.core.ApiFunction<? super X,? extends V>) in com.google.api.core.ApiFutures has been deprecated
@chingor13
Copy link
Contributor

This looks like it should be filed against google-cloud-java

@chingor13 chingor13 transferred this issue from googleapis/google-http-java-client Jun 3, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Jun 4, 2019
@chingor13 chingor13 added the type: cleanup An internal cleanup or hygiene concern. label Jun 5, 2019
@yoshi-automation yoshi-automation removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Jun 5, 2019
@abhinav-qlogic
Copy link

abhinav-qlogic commented Jun 24, 2019

Most of these depreciation were handled with already opened issue #4384. I believe only two deprecation are remained to fix:
SinkInfo.java:[586,13] setOutputVersionFormat(...)
SinkInfo.java:[599,58] getOutputVersionFormat()
We are actually trying to figure out alternative ways to set and get the same but it seems there aren't any.
Could you please let us know If we should continue to these two deprecated methods? OR Remove these method uses (As LogSink is always going to defaults to v2)?

@chingor13 chingor13 changed the title com.google.api.core.ApiFutures has been deprecated deprecations showed up in build Deprecation warnings showing up in build logs Jul 8, 2019
@chingor13
Copy link
Contributor

@abhinav-qlogic We should remove the usage of those methods, but maintain the current behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants