Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style presubmits failing #4438

Closed
igorbernstein2 opened this issue Feb 4, 2019 · 0 comments
Closed

Code style presubmits failing #4438

igorbernstein2 opened this issue Feb 4, 2019 · 0 comments
Assignees
@kolea2
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@igorbernstein2
Copy link

I think the kokoro code style presubmit has changed and considers the code in this repo problematic. To see what kokoro see run:

mvn com.coveo:fmt-maven-plugin:2.8:check

To update the code run:
mvn com.coveo:fmt-maven-plugin:2.8:format

But I think this needs to done in the synth scripts as well
@igorbernstein2 igorbernstein2 added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Feb 4, 2019
@igorbernstein2 igorbernstein2 mentioned this issue Feb 4, 2019
Merged
@kolea2 kolea2 mentioned this issue Feb 4, 2019
Merged
@kolea2 kolea2 mentioned this issue Feb 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kolea2 kolea2

Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@igorbernstein2 @kolea2