Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigtable: investigate GCRule.fromProto being incorrect #4057

Closed
igorbernstein2 opened this issue Nov 20, 2018 · 3 comments · Fixed by #4990
Closed

Bigtable: investigate GCRule.fromProto being incorrect #4057

igorbernstein2 opened this issue Nov 20, 2018 · 3 comments · Fixed by #4990
Assignees
@igorbernstein2
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@igorbernstein2
Copy link

igorbernstein2 commented Nov 20, 2018 •
edited
Loading

From a user:

GCRule and GcRule classes are confusing and .fromProto() conversion does not work properly in some cases. Not 100% sure which scenario it was, but I think we were setting maxversions and maxage, and only one of them was in the final result after calling .fromProto().
@igorbernstein2 igorbernstein2 self-assigned this Nov 20, 2018
@igorbernstein2 igorbernstein2 added api: bigtable Issues related to the Bigtable API. and removed api: bigtable Issues related to the Bigtable API. labels Nov 20, 2018
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Nov 21, 2018
@sduskis sduskis added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Nov 21, 2018
@sduskis
Copy link
Contributor

sduskis commented Nov 21, 2018

@igorbernstein2, and additional info would be helpful.

@sduskis sduskis mentioned this issue Nov 21, 2018
Merged
@igorbernstein2
Copy link
Author

I updated the description

@sduskis
Copy link
Contributor

sduskis commented Apr 16, 2019

@rahulKQL, can you please look at this?

@rahulKQL rahulKQL mentioned this issue Apr 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igorbernstein2 igorbernstein2

Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bigtable: Added unit tests for GCRule#fromProto rahulKQL/google-cloud-java
3 participants
@sduskis @JustinBeckwith @igorbernstein2