Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigTableAdmin integration tests fail when run in parallel #3883

Closed
chingor13 opened this issue Oct 31, 2018 · 2 comments
Closed

BigTableAdmin integration tests fail when run in parallel #3883

chingor13 opened this issue Oct 31, 2018 · 2 comments
Assignees
@igorbernstein2
Labels
api: bigtable Issues related to the Bigtable API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: cleanup An internal cleanup or hygiene concern.

Comments

@chingor13
Copy link
Contributor

When multiple jobs are running the BigTableAdmin integration tests, they collide as they share table names. Make the tables unique per run so they can be run in parallel.

The storage integration tests do something similar with buckets to prevent collisions.
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: cleanup An internal cleanup or hygiene concern. api: bigtable Issues related to the Bigtable API. labels Oct 31, 2018
@chingor13 chingor13 mentioned this issue Oct 31, 2018
Merged
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Nov 1, 2018
@chingor13 chingor13 added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Nov 1, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Nov 1, 2018
@chingor13
Copy link
Contributor Author

This is causing a bunch of pain when we're working on multiple PRs.

@sduskis
Copy link
Contributor

sduskis commented Nov 1, 2018

@igorbernstein2, we brought this up this week. Would you mind finding a solution for this?

@igorbernstein2 igorbernstein2 mentioned this issue Nov 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igorbernstein2 igorbernstein2

Labels
api: bigtable Issues related to the Bigtable API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chingor13 @sduskis @JustinBeckwith @igorbernstein2