Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect directories even when not ending with "/" #3774

Closed
jean-philippe-martin opened this issue Oct 5, 2018 · 0 comments · Fixed by #3775
Closed

Detect directories even when not ending with "/" #3774

jean-philippe-martin opened this issue Oct 5, 2018 · 0 comments · Fixed by #3775
Assignees
Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: in progress There is an open PR type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@jean-philippe-martin
Copy link

The current implementation of PseudoDirectories has Files.isDirectory(path) return true only if path ends with a slash.

Users would be less surprised if instead of this behavior, we tried harder to identify things that look like directories.

So for example if foo/bar.txt exists, the following paths should be treated as directories:

  • foo/
  • foo
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Oct 5, 2018
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 5, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Oct 5, 2018
@chingor13 chingor13 self-assigned this Oct 9, 2018
@chingor13 chingor13 added api: storage Issues related to the Cloud Storage API. status: in progress There is an open PR labels Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: in progress There is an open PR type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants