Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigtableDataClient is missing sync methods #3635

Closed
7 tasks
ajaaym opened this issue Sep 1, 2018 · 4 comments
Closed
7 tasks

BigtableDataClient is missing sync methods #3635

ajaaym opened this issue Sep 1, 2018 · 4 comments
Assignees
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ajaaym
Copy link
Contributor

ajaaym commented Sep 1, 2018

Add below sync method in BigtableDataClient.

  • readRow
  • readRows
  • sampleRowKeys
  • mutateRow
  • bulkMutateRows
  • checkAndMutateRow
  • readModifyWriteRow
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Sep 2, 2018
@sduskis sduskis added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: bigtable Issues related to the Bigtable API. and removed triage me I really want to be triaged. labels Sep 4, 2018
@igorbernstein2
Copy link

Currently each rpc has 2 entrypoints: callable and async. I don't think it makes sense to add sync variant for only readRow. So I think this should be expanded to include a sync variant for all RPCs

@ajaaym
Copy link
Contributor Author

ajaaym commented Sep 5, 2018

Agree. Should include sync variant of all RPCs.

@sduskis sduskis removed their assignment Oct 12, 2018
@sduskis
Copy link
Contributor

sduskis commented Oct 12, 2018

@elisheva-qlogic, can you please look at this one?

@igorbernstein2
Copy link

It should be pretty straight forward to add sync variants for all of the methods:
for readRow:

public Row readRow(String tableId, ByteString rowKey) {
  return ApiExceptions.callAndTranslateApiException(readRowAsync(tableId, rowKey));
}

@ajaaym ajaaym changed the title BigtableDataClient is missing sync readRow BigtableDataClient is missing sync methods Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants