Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraceLoggingEnhancer sets trace ID in the wrong field #3280

Closed
joaoandremartins opened this issue May 16, 2018 · 1 comment
Closed

TraceLoggingEnhancer sets trace ID in the wrong field #3280

joaoandremartins opened this issue May 16, 2018 · 1 comment
Assignees
@andreamlin
Labels
api: logging Issues related to the Cloud Logging API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@joaoandremartins
Copy link

The trace ID of a log entry is being set in the wrong field (label).

In order for the log entries to be linked to the trace, the TraceLoggingEnhancer needs to look something like this.

  1. Use setTrace(), not setLabel()
  2. Use a project/myProjectId/traces/myTraceId format.
@joaoandremartins joaoandremartins mentioned this issue May 17, 2018
Merged
@andreamlin andreamlin self-assigned this May 18, 2018
@andreamlin andreamlin added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: logging Issues related to the Cloud Logging API. labels May 18, 2018
@andreamlin
Copy link
Contributor

Pull request: #3301

@andreamlin andreamlin mentioned this issue May 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreamlin andreamlin

Labels
api: logging Issues related to the Cloud Logging API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaoandremartins @andreamlin