Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLP : Default application credentials are not getting picked up when running locally #2231

Closed
jabubake opened this issue Jul 11, 2017 · 10 comments
Assignees
Labels
api: dlp Issues related to the Sensitive Data Protection API. auth priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@jabubake
Copy link
Contributor

Running code locally gives me:
"Error in inspectString: io.grpc.StatusRuntimeException: PERMISSION_DENIED: DLP API has not been used in project usable-auth-library before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/dlp.googleapis.com/overview?project=usable-auth-library then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry."

I need to explicitly provide GOOGLE_APPLICATION_CREDENTIALS env var, gcloud auth application-default login does not work.

@garrettjonesgoogle garrettjonesgoogle added api: dlp Issues related to the Sensitive Data Protection API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 17, 2017
@chanseokoh
Copy link
Contributor

AFAIK, usable-auth-library is an internal project assigned to gcloud, and there may be a reason that the Cloud SDK team did not enable the DLP API. I know the team cannot enable APIs if the APIs end up charging the internal project.

BTW, The DLP quickstart does not list Cloud SDK as a requirement, and it should work without gcloud installed: https://cloud.google.com/dlp/docs/quickstart-cli. Maybe it's intended that you should use GOOGLE_APPLICATION_CREDENTIALS as described in the quickstart?

@garrettjonesgoogle
Copy link
Member

We need to update the error we are seeing about the project project usable-auth-library, and guide people to use service account credentials instead.

@pongad
Copy link
Contributor

pongad commented Jan 18, 2018

Is there an action item here? IIUC, setting GOOGLE_APPLICATION_CREDENTIALS is recommneded per auth documentation

@chanseokoh
Copy link
Contributor

One action item I suggest: make DLP not pick up the gcloud application default credential. The confusing error message about the gcloud project is because of this.

BTW, DLP is probably not the only API that is disabled in the gcloud project.

@pongad
Copy link
Contributor

pongad commented Jan 19, 2018

@garrettjonesgoogle I believe the gcloud default credential is automatically looked up by GoogleCredentials.getApplicationDefault which also looks up GOOGLE_APPLICATION_CREDENTIALS env var right?

@chanseokoh To make sure I understand you right, we should ignore the gcloud default (set on gcloud command) but continue to look up the env var?

@chanseokoh
Copy link
Contributor

@pongad yeah, I think that is ideal, for APIs like DLP for which the internal gcloud project specifically disables. It should of course be able to get a credential through the env var.

@garrettjonesgoogle
Copy link
Member

@pongad I believe your understanding is correct.

@pongad
Copy link
Contributor

pongad commented Feb 5, 2018

I did some more digging. We are discouraging people and APIs from using gcloud auth application-default login and intend to deprecate this mechanism. Setting the env var is the preferable method.

I'll close this as wontfix. Eventually, I believe the auth library should stop working with the gcloud command altogether. cc @vchudnov-g

@pongad pongad closed this as completed Feb 5, 2018
@jabubake
Copy link
Contributor Author

jabubake commented Feb 5, 2018

@pongad : fine with this not working, but can we provide a better error message to the user here to ask them to set GOOGLE_APPLICATION_CREDENTIALS or link them to the right auth docs ?

@jabubake jabubake reopened this Feb 5, 2018
@vchudnov-g
Copy link

@jabubake Internally, b/64388723 tracks the implementation of the better error message. I've added you to the cc list on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dlp Issues related to the Sensitive Data Protection API. auth priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

6 participants