Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for PubSub high-perf client integration #1493

Closed
6 tasks
pongad opened this issue Dec 21, 2016 · 5 comments
Closed
6 tasks

Tracking issue for PubSub high-perf client integration #1493

pongad opened this issue Dec 21, 2016 · 5 comments
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API.

Comments

@pongad
Copy link
Contributor

pongad commented Dec 21, 2016

This issue tracks items we need to do to go from "the code works" to "we're happy with it"

  • Document explaining migration to HP client
  • Figure out the proper configuration for Publisher and Subscriber
  • Sample code
    • Publisher
    • Subscriber
  • Code snippets
    • Publisher
    • Subscriber
@pongad
Copy link
Contributor Author

pongad commented Jan 6, 2017

@davidtorres , I have a couple of questions.

  • PubSub already has executor for dealing with retry/timeout. Is sharing the executor with publisher/subscriber a "reasonable default"
  • It looks like every SubscriberConnection has its own channel. I thought having many channels is an anti-pattern?

@davidtorres
Copy link

  • I prefer if we keep separate executors for publisher and subscriber (but also give the alternative for the user to provide his own executor). The reason being that it is easier to debug thread starvation problems and thread dumps when the executors are separate (i.e. you don't want the subscriber executor to starve the publisher if having problems to pull, renew-deadlines, etc)

@davidtorres
Copy link

  • In regards to the multiple channels, we need many channels in order to achieve the desired throughput

@garrettjonesgoogle
Copy link
Member

@pongad we may have taken care of enough of this tracking issue - maybe close it out, and if there are any tail-end tasks, create separate issues for them. I would like to avoid zombie issues.

@pongad
Copy link
Contributor Author

pongad commented Feb 23, 2017

This was a tracking issue for bundling implementation integration. That work is much more long term than I thought previously. Let's close it out.

@pongad pongad closed this as completed Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

No branches or pull requests

3 participants