Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking changes are labeled as Feature changes in the library-specific CHANGELOG #10844

Closed
burkedavison opened this issue May 15, 2024 · 3 comments · Fixed by #11068
Closed

Breaking changes are labeled as Feature changes in the library-specific CHANGELOG #10844

burkedavison opened this issue May 15, 2024 · 3 comments · Fixed by #11068
Assignees
@suztomo
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@burkedavison
Copy link
Member

Breaking changes in the root CHANGELOG are only 'Feature' changes in the client library's CHANGELOG.

image
vs
image
@burkedavison burkedavison added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label May 15, 2024
@lqiu96 lqiu96 added the priority: p2 Moderately-important priority. Fix may not be included in next release. label May 20, 2024
@blakeli0
Copy link
Contributor

blakeli0 commented Aug 9, 2024

Looks like we are grouping all changes into either features or dependencies in the scripts, was this by design @suztomo?

Separately, the duplicated entry is because of the duplicated entries in release notes, which is still an issue but should probably be tracked differently.

@suztomo
Copy link
Member

suztomo commented Aug 9, 2024

I didn't incorporate the breaking change section as it's rare. I think this issue and desire to enhance it are valid.

@suztomo suztomo self-assigned this Aug 12, 2024
@suztomo
Copy link
Member

suztomo commented Aug 12, 2024

Looking into this.

@suztomo suztomo mentioned this issue Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suztomo suztomo

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: release note generation to handle breaking changes suztomo/google-cloud-java
4 participants
@suztomo @blakeli0 @lqiu96 @burkedavison