From fe98cb412dfbcf9c87dbf120cf5dc25f11781ae1 Mon Sep 17 00:00:00 2001 From: Marco Ziccardi Date: Mon, 26 Oct 2015 09:45:56 +0100 Subject: [PATCH] Remove storage todos (replaced with issues: #288 #289 #290 #291 #292) --- .../src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java | 3 --- .../src/main/java/com/google/gcloud/storage/StorageImpl.java | 2 -- 2 files changed, 5 deletions(-) diff --git a/gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java b/gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java index 52820171cf29..90f2c98ad4b8 100644 --- a/gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java +++ b/gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java @@ -293,7 +293,6 @@ public StorageObject compose(Iterable sources, StorageObject targ Map targetOptions) throws StorageException { ComposeRequest request = new ComposeRequest(); if (target.getContentType() == null) { - // todo: remove once this is no longer requirement (b/20681287). target.setContentType("application/octet-stream"); } request.setDestination(target); @@ -311,7 +310,6 @@ public StorageObject compose(Iterable sources, StorageObject targ } request.setSourceObjects(sourceObjects); try { - // todo: missing setProjection (b/20659000) return storage.objects() .compose(target.getBucket(), target.getName(), request) .setIfMetagenerationMatch(IF_METAGENERATION_MATCH.getLong(targetOptions)) @@ -435,7 +433,6 @@ public byte[] read(StorageObject from, Map options, long position, in .setIfGenerationMatch(IF_GENERATION_MATCH.getLong(options)) .setIfGenerationNotMatch(IF_GENERATION_NOT_MATCH.getLong(options)); MediaHttpDownloader downloader = req.getMediaHttpDownloader(); - // todo: Fix int casting (https://github.com/google/google-api-java-client/issues/937) downloader.setContentRange(position, (int) position + bytes); downloader.setDirectDownloadEnabled(true); ByteArrayOutputStream output = new ByteArrayOutputStream(); diff --git a/gcloud-java-storage/src/main/java/com/google/gcloud/storage/StorageImpl.java b/gcloud-java-storage/src/main/java/com/google/gcloud/storage/StorageImpl.java index 6edd2713fded..b6292e1cdf87 100644 --- a/gcloud-java-storage/src/main/java/com/google/gcloud/storage/StorageImpl.java +++ b/gcloud-java-storage/src/main/java/com/google/gcloud/storage/StorageImpl.java @@ -102,8 +102,6 @@ public RetryResult beforeEval(Exception exception) { StorageImpl(StorageOptions options) { super(options); storageRpc = options.storageRpc(); - // todo: provide rewrite - https://cloud.google.com/storage/docs/json_api/v1/objects/rewrite - // todo: check if we need to expose https://cloud.google.com/storage/docs/json_api/v1/bucketAccessControls/insert vs using bucket update/patch } @Override