diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java b/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java
index eba6a51c4f01..877ec591915a 100644
--- a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java
+++ b/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java
@@ -383,38 +383,37 @@ public ApiFuture
getTableAsync(String tableId) {
}
/**
- * Lists all TableNames in the instance.
+ * Lists all table ids in the instance.
*
* Sample code:
*
*
{@code
- * List tableNames = client.listTables();
- * for(TableName name : tableNames) {
+ * List tableIds = client.listTables();
+ * for(String tableId: tableIds) {
* System.out.println(name.getTable());
* }
* }
*/
- // TODO(igorbernstein2): consider changing this method to use relative table ids.
@SuppressWarnings("WeakerAccess")
- public List listTables() {
+ public List listTables() {
return awaitFuture(listTablesAsync());
}
/**
- * Asynchronously lists all TableNames in the instance.
+ * Asynchronously lists all table ids in the instance.
*
* Sample code:
*
*
{@code
- * ApiFuture> listFuture = client.listTables();
+ * ApiFuture> listFuture = client.listTables();
*
* ApiFutures.addCallback(
* listFuture,
- * new ApiFutureCallback>() {
- * public void onSuccess(List tableNames) {
+ * new ApiFutureCallback>() {
+ * public void onSuccess(List tableIds) {
* System.out.println("Got list of tables:");
- * for (TableName name : tableNames) {
- * System.out.println(name.getTable());
+ * for (String tableId : tableIds) {
+ * System.out.println(tableId);
* }
* }
*
@@ -426,9 +425,8 @@ public List listTables() {
* );
* }
*/
- // TODO(igorbernstein2): consider changing this method to use relative table ids.
@SuppressWarnings("WeakerAccess")
- public ApiFuture> listTablesAsync() {
+ public ApiFuture> listTablesAsync() {
ListTablesRequest request = ListTablesRequest.newBuilder().setParent(instanceName.toString())
.build();
@@ -479,12 +477,12 @@ public ApiFuture> apply(
// Wrap all of the accumulated protos.
return ApiFutures.transform(allProtos,
- new ApiFunction, List>() {
+ new ApiFunction, List>() {
@Override
- public List apply(List protos) {
- List results = Lists.newArrayListWithCapacity(protos.size());
+ public List apply(List protos) {
+ List results = Lists.newArrayListWithCapacity(protos.size());
for (com.google.bigtable.admin.v2.Table proto : protos) {
- results.add(TableName.parse(proto.getName()));
+ results.add(TableName.parse(proto.getName()).getTable());
}
return results;
}
diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java
index 33b6a8b410d3..74bd2b7dcce9 100644
--- a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java
+++ b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java
@@ -241,12 +241,12 @@ public void testListTables() {
);
// Execute
- List actualResults = adminClient.listTables();
+ List actualResults = adminClient.listTables();
// Verify
- List expectedResults = Lists.newArrayList();
+ List expectedResults = Lists.newArrayList();
for (com.google.bigtable.admin.v2.Table expectedProto : expectedProtos) {
- expectedResults.add(TableName.parse(expectedProto.getName()));
+ expectedResults.add(TableName.parse(expectedProto.getName()).getTable());
}
assertThat(actualResults).containsExactlyElementsIn(expectedResults);
diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java
index e79120dec693..92d92e62cb52 100644
--- a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java
+++ b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java
@@ -22,7 +22,6 @@
import static org.junit.Assert.assertTrue;
import com.google.bigtable.admin.v2.InstanceName;
-import com.google.bigtable.admin.v2.TableName;
import com.google.cloud.bigtable.admin.v2.BigtableTableAdminClient;
import com.google.cloud.bigtable.admin.v2.models.ColumnFamily;
import com.google.cloud.bigtable.admin.v2.models.CreateTableRequest;
@@ -204,7 +203,7 @@ public void listTables() {
try {
tableAdmin.createTable(CreateTableRequest.of(tableId));
- List tables = tableAdmin.listTables();
+ List tables = tableAdmin.listTables();
assertNotNull(tables);
assertFalse("List tables did not return any tables", tables.isEmpty());
} finally {
@@ -218,7 +217,7 @@ public void listTablesAsync() throws Exception {
try {
tableAdmin.createTable(CreateTableRequest.of(tableId));
- List tables = tableAdmin.listTablesAsync().get();
+ List tables = tableAdmin.listTablesAsync().get();
assertNotNull(tables);
assertFalse("List tables did not return any tables", tables.isEmpty());
} finally {