From 2071a09d80233a55c5950405f883b637117f54e5 Mon Sep 17 00:00:00 2001 From: mohanli-ml Date: Mon, 18 Dec 2023 21:45:53 +0000 Subject: [PATCH] feat(bigtable/spanner): remove grpclb --- bigtable/bigtable.go | 3 --- spanner/client.go | 1 - 2 files changed, 4 deletions(-) diff --git a/bigtable/bigtable.go b/bigtable/bigtable.go index 0cd7a7084f08..3a0481d876a2 100644 --- a/bigtable/bigtable.go +++ b/bigtable/bigtable.go @@ -85,9 +85,6 @@ func NewClientWithConfig(ctx context.Context, project, instance string, config C // Set the max size to correspond to server-side limits. option.WithGRPCDialOption(grpc.WithDefaultCallOptions(grpc.MaxCallSendMsgSize(1<<28), grpc.MaxCallRecvMsgSize(1<<28))), ) - // Attempts direct access to spanner service over gRPC to improve throughput, - // whether the attempt is allowed is totally controlled by service owner. - o = append(o, internaloption.EnableDirectPath(true)) o = append(o, opts...) connPool, err := gtransport.DialPool(ctx, o...) if err != nil { diff --git a/spanner/client.go b/spanner/client.go index 52cc320a74ff..b9d5404e87ef 100644 --- a/spanner/client.go +++ b/spanner/client.go @@ -303,7 +303,6 @@ func allClientOpts(numChannels int, compression string, userOpts ...option.Clien clientDefaultOpts := []option.ClientOption{ option.WithGRPCConnectionPool(numChannels), option.WithUserAgent(fmt.Sprintf("spanner-go/v%s", internal.Version)), - internaloption.EnableDirectPath(true), internaloption.AllowNonDefaultServiceAccount(true), } if compression == "gzip" {