-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bttest): Reject empty regex row filters #6520
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
I've now rebased the branch onto the current version of main. I don't know how the CI system is set up in this repo. Is the "kokoro" step causing it to block? |
This fixes GitHub issue #6519; see that issue for further commentary.
Yeah, the CI can cause it to block. I'll try to get this PR unstuck. |
This fixes GitHub issue googleapis#6519; see that issue for further commentary. Co-authored-by: Eric Schmidt <[email protected]>
This fixes GitHub issue #6519; see that issue for further commentary.