From 70d348670b43ac0172dbf3faac4c349b4ea179ff Mon Sep 17 00:00:00 2001 From: BrennaEpp Date: Wed, 31 Jul 2024 11:44:48 -0700 Subject: [PATCH 1/2] fix(storage): add unknown host to retriable errors --- storage/invoke.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/storage/invoke.go b/storage/invoke.go index 5d71533d09ea..3bca1f97d893 100644 --- a/storage/invoke.go +++ b/storage/invoke.go @@ -124,6 +124,10 @@ func ShouldRetry(err error) bool { return true } } + case *net.DNSError: + if strings.Contains(e.Error(), "no such host") { + return true + } case interface{ Temporary() bool }: if e.Temporary() { return true From bed23bf68e37e0bb8fe04c7661f0c0cabc26c6cd Mon Sep 17 00:00:00 2001 From: BrennaEpp Date: Mon, 23 Sep 2024 14:24:25 -0600 Subject: [PATCH 2/2] use DNSError.Temporary --- storage/invoke.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/storage/invoke.go b/storage/invoke.go index 3bca1f97d893..c6a647a9872f 100644 --- a/storage/invoke.go +++ b/storage/invoke.go @@ -125,7 +125,7 @@ func ShouldRetry(err error) bool { } } case *net.DNSError: - if strings.Contains(e.Error(), "no such host") { + if e.IsTemporary { return true } case interface{ Temporary() bool }: