feat(bigtable/spanner): remove grpclb #9186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
product-auto-label
bot
added
the
stale: old
|
@mohanli-ml What's the status of this, do we still need it? |
|
Yes. Bigtable and Spanner has deprecated any DirectPath usage with gRPCLB, and they will only use DirectPath with Traffic Director in the future. So we should remove this option. |
|
LGTM for bigtable changes |
|
Ignore the conformance test failures. The tests were added in failed state. |
bhshkh
approved these changes
Feb 10, 2024
product-auto-label
bot
added
stale: extraold
|
@rahul2393 can we get your approval on this as well? |
rahul2393
approved these changes
Mar 8, 2024
rahul2393
approved these changes
Apr 16, 2024
This was referenced Apr 17, 2024
HailongWen
added a commit
to HailongWen/google-cloud-go
that referenced
this pull request
Apr 17, 2024
This is to counter googleapis#9186. Previously `EnableDirectPath` is default to true. With the removal we need to explicitly set it.
HailongWen
added a commit
to HailongWen/google-cloud-go
that referenced
this pull request
Apr 18, 2024
This is broken by googleapis#9186. We need to explicitly set `EnableDirectPath` to true.
rahul2393
pushed a commit
that referenced
this pull request
Apr 20, 2024
This is broken by #9186. We need to explicitly set `EnableDirectPath` to true.
jschaf
pushed a commit
to jschaf/spanner-go
that referenced
this pull request
Oct 10, 2024
This is broken by googleapis/google-cloud-go#9186. We need to explicitly set `EnableDirectPath` to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove attempt DirectPath gRPCLB by default in Bigtable and Spanner because: