Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub/pstest: Support for subscription filters #8582

Closed
andreas-lindfalk opened this issue Sep 15, 2023 · 2 comments · Fixed by #9015
Closed

pubsub/pstest: Support for subscription filters #8582

andreas-lindfalk opened this issue Sep 15, 2023 · 2 comments · Fixed by #9015
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@andreas-lindfalk
Copy link

andreas-lindfalk commented Sep 15, 2023

Is your feature request related to a problem? Please describe.
Nor the pubsub emulator or pstest support subscription filters, making it impossible to integrationtest a pubsub setup making use of filters today.

Describe the solution you'd like
There is an embryo in pstest for filters, they can be set and updated and there is a filterMsgs func where filters could be applied according to the documented filter rules. In other words, implement support for subscription filters in pstest

Describe alternatives you've considered
As mentioned, the pubsub emulator does not support subscription filters either…

Additional context
I could take a stab at implementing this if you peps at Google have limited resources ;)

@andreas-lindfalk andreas-lindfalk added the triage me I really want to be triaged. label Sep 15, 2023
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Sep 15, 2023
@hongalex hongalex added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Sep 18, 2023
@hongalex
Copy link
Member

Hey, thanks for bringing this up. Yeah unfortunately supporting filtering in either the emulator and the fake is not a high priority item currently.

If you have a PR to send over, I would be happy to look it over and find a way to get that merged in. Would require signing a CLA

@zezhehh
Copy link
Contributor

zezhehh commented Nov 16, 2023

Hey, thanks for bringing this up. Yeah unfortunately supporting filtering in either the emulator and the fake is not a high priority item currently.

If you have a PR to send over, I would be happy to look it over and find a way to get that merged in. Would require signing a CLA

Just submitted a PR. It would be great if you could take a look :D
#9015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants