Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): support single-shot uploads in gRPC #8348

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Jul 28, 2023

When ChunkSize is zero, use a single shot upload (leaving the stream open between messages) rather than a resumable session. This matches better with what we do in JSON. Also reduce the buffer size to the minimum (256k).

Fixes #7798

When ChunkSize is zero, use a single shot upload (leaving the
stream open between messages) rather than a resumable session.
This matches better with what we do in JSON. Also reduce the
buffer size to the minimum (256k).

Fixes googleapis#7798
@tritone tritone requested review from a team as code owners July 28, 2023 21:43
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the Cloud Storage API. labels Jul 28, 2023
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Glad you/we had the forethought to put those TODOs in there.

@tritone tritone added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Aug 1, 2023
@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Aug 1, 2023
Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcf-merge-on-green gcf-merge-on-green bot merged commit 7de4a7d into googleapis:main Aug 1, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: determine what to do on chunksize=0 [GRPC]
3 participants