Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigtable: stream terminated by RST_STREAM with error code: INTERNAL_ERROR is not retried by client #6476

Closed
aravindsrinivasan opened this issue Aug 4, 2022 · 3 comments · Fixed by #9673
Assignees
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@aravindsrinivasan
Copy link

Package: cloud.google.com/go/bigtable v1.13.0

When our bigtable instance has high throughput we see the following error on occasion:

rpc error: code = Internal desc = stream terminated by RST_STREAM with error code: INTERNAL_ERROR

This to me looks like a transient error that should be retried by the client. I see the Spanner client retrying this exact error:

// Retry returns the retry delay returned by Cloud Spanner if that is present.
// Otherwise it returns the retry delay calculated by the generic gax Retryer.
func (r *spannerRetryer) Retry(err error) (time.Duration, bool) {
if status.Code(err) == codes.Internal &&
!strings.Contains(err.Error(), "stream terminated by RST_STREAM") &&
// See b/25451313.
!strings.Contains(err.Error(), "HTTP/2 error code: INTERNAL_ERROR") &&
// See b/27794742.
!strings.Contains(err.Error(), "Connection closed with unknown cause") &&
!strings.Contains(err.Error(), "Received unexpected EOS on DATA frame from server") {
return 0, false
}

Could also do the same in the Bigtable client? Or is this error actually not retryable in the context of Bigtable?

@aravindsrinivasan aravindsrinivasan added the triage me I really want to be triaged. label Aug 4, 2022
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Aug 4, 2022
@telpirion telpirion added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Aug 11, 2022
@telpirion telpirion assigned triplequark and unassigned telpirion Nov 4, 2022
@aravindsrinivasan
Copy link
Author

Any update here?

@nainya
Copy link

nainya commented Mar 21, 2023

Any updates here?

@bhshkh bhshkh self-assigned this Mar 5, 2024
@bhshkh
Copy link
Contributor

bhshkh commented Mar 28, 2024

Not yet picked up. Will pick up soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants