Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spannertest: add support for dropping Foreign Keys #6254

Closed
gmontagu opened this issue Jun 24, 2022 · 0 comments · Fixed by #6608
Closed

spannertest: add support for dropping Foreign Keys #6254

gmontagu opened this issue Jun 24, 2022 · 0 comments · Fixed by #6608
Assignees
Labels
api: spanner Issues related to the Spanner API. priority: p3 Desirable enhancement or fix. May not be included in next release. 🚨 This issue needs some love.

Comments

@gmontagu
Copy link

gmontagu commented Jun 24, 2022

Is your feature request related to a problem? Please describe.
When testing a SQL migration DDL statement and attempting to drop a Foreign Key from a table, spannertest throws the error: (details: rpc error: code = Unimplemented desc = unhandled DDL table alteration type spansql.DropConstraint)

Describe the solution you'd like
Support for DROP CONSTRAINT call when using spannertest.

Describe alternatives you've considered
Forgoing adding the DDL statement to the migration script and manually running the command against spanner. But then we lose the ability to spin up new in memory spanner instances with this constraint droppd.

Additional context
Additional options are also not yet supported:
SET OPTIONS - ALTER TABLE {table} ALTER COLUMN {column} SET OPTIONS (allow_commit_timestamp=true);

@gmontagu gmontagu added the triage me I really want to be triaged. label Jun 24, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jun 24, 2022
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 29, 2022
@rahul2393 rahul2393 added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. priority: p3 Desirable enhancement or fix. May not be included in next release. 🚨 This issue needs some love.
Projects
None yet
3 participants