Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: (and all packages): Support bazel builds #6128

Open
gonzojive opened this issue Jun 6, 2022 · 3 comments
Open

storage: (and all packages): Support bazel builds #6128

gonzojive opened this issue Jun 6, 2022 · 3 comments
Assignees
@noahdietz
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@gonzojive
Copy link

Is your feature request related to a problem? Please describe.
Please see bazel-contrib/rules_go#2981

Upgrading past v1.15.0 of the storage API broke many bazel-based builds. Please consider adding support for such users including tests to your CI.
@gonzojive gonzojive added the triage me I really want to be triaged. label Jun 6, 2022
@codyoss codyoss added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the Cloud Storage API. and removed triage me I really want to be triaged. labels Jun 7, 2022
@codyoss
Copy link
Member

codyoss commented Jun 7, 2022

cc @noahdietz

I think this is most likely a rules_go issue. Seems like it might be related to bazel-contrib/rules_go#1986. Without the changes in the linked issue addressed I don't think we can support rules_go at this time.

@noahdietz
Copy link
Contributor

@gonzojive thanks for filing this bug. It helps us learn more about who is effected and how. I've added this issue as an example breakage to a doc I'm going to circulate. http://go/fix-rules-go-googleapis

@tritone tritone assigned noahdietz and unassigned tritone Jun 9, 2022
@flakrimjusufi flakrimjusufi mentioned this issue Jun 29, 2022
Closed
@codyoss
Copy link
Member

codyoss commented Jul 6, 2023

I believe this should be better now and keep getting better as a few more bazel/gazzel changes roll out over the next month or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahdietz noahdietz

Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gonzojive @tritone @codyoss @noahdietz