feat(spanner): enable row.ToStructLenient to work with STRUCT data type #5944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
rahul2393
requested review from
olavloite and
codyoss
and removed request for
codyoss
olavloite
reviewed
Apr 26, 2022
spanner/value.go
Outdated
| @@ -986,7 +986,7 @@ func parseNullTime(v *proto3.Value, p *NullTime, code sppb.TypeCode, isNull bool | |||
|
|
|||
| // decodeValue decodes a protobuf Value into a pointer to a Go value, as | |||
| // specified by sppb.Type. | |||
| func decodeValue(v *proto3.Value, t *sppb.Type, ptr interface{}) error { | |||
| func decodeValue(v *proto3.Value, t *sppb.Type, ptr interface{}, opts ...bool) error { | |||
There was a problem hiding this comment.
Would it maybe be better to create a decodeValueOption interface and pass that in instead of booleans? This means that we can only have boolean options, which both limit the types of options that we can have, but also makes them very 'magical'. Imagine that we support 3 options; no-one will understand what decodeValue(v, t, true, false, false) means.
There was a problem hiding this comment.
Thanks, updated the PR please take a look again.
olavloite
approved these changes
Apr 26, 2022
spanner/value.go
Outdated
| @@ -3043,6 +3049,22 @@ func errDecodeStructField(ty *sppb.StructType, f string, err error) error { | |||
| return se | |||
| } | |||
|
|
|||
| // DecodeSetting contains all the settings for decoding from spanner struct | |||
| type DecodeSetting struct { | |||
There was a problem hiding this comment.
nit: I think we can make this unexported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5938