Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: support user-defined headers passed via the context.Context metadata #5385

Closed
noahdietz opened this issue Jan 20, 2022 · 1 comment · Fixed by #8294
Closed

storage: support user-defined headers passed via the context.Context metadata #5385

noahdietz opened this issue Jan 20, 2022 · 1 comment · Fixed by #8294
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@noahdietz
Copy link
Contributor

Today, the JSON client surface requires that an entire custom HTTPClient be provided to have an end-user's own request headers included in API calls. This is a cumbersome experience. gRPC clients support "headers" via the context.Context metadata of the context provided at call time to ever method. This is a straight forward and clean way to support user-specified header injection. We should consider adding support for it at the client level in the same fashion.

cc: @tritone
@noahdietz noahdietz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the Cloud Storage API. labels Jan 20, 2022
@noahdietz noahdietz self-assigned this Jan 20, 2022
@tritone
Copy link
Contributor

tritone commented Jul 28, 2023

This is now supported at the apiary layer via the callctx package. I add support for XML storage methods and add docs to the storage package describing how to do this in a PR here: #8294

@tritone tritone assigned tritone and unassigned noahdietz Jul 28, 2023
@tritone tritone mentioned this issue Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(storage): add support for custom headers tritone/google-cloud-go
2 participants
@tritone @noahdietz