Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: Scope constants removed #3683

Closed
sinmetal opened this issue Feb 9, 2021 · 2 comments · Fixed by #3684
Closed

spanner: Scope constants removed #3683

sinmetal opened this issue Feb 9, 2021 · 2 comments · Fixed by #3684
Assignees
@skuruppu
Labels
api: spanner Issues related to the Spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@sinmetal
Copy link
Contributor

sinmetal commented Feb 9, 2021

This PR has removed the Scope and AdminScope constants.

549c351#diff-a7eef968d026e320839e33486c1ce4e449d69d9f6c86052edeae4528b60b5579L50-L57

These are constants that were exported, so they correspond to Breaking Change.
I was referencing this constant, so I got a compile error.

I think these constants should be reverted or listed in the Release Note as a Breaking Change.

Additional context

Started after upgrading to v1.14.0.
@sinmetal sinmetal added the triage me I really want to be triaged. label Feb 9, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Feb 9, 2021
@codyoss codyoss added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. labels Feb 9, 2021
@codyoss codyoss mentioned this issue Feb 9, 2021
Merged
@codyoss
Copy link
Member

codyoss commented Feb 9, 2021

@sinmetal Thanks for bringing this up. This was unintentionally removed. We will get a patch out shortly.

@codyoss
Copy link
Member

codyoss commented Feb 9, 2021

https://github.com/googleapis/google-cloud-go/releases/tag/spanner%2Fv1.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skuruppu skuruppu

Labels
api: spanner Issues related to the Spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(spanner): restore removed scopes
3 participants
@sinmetal @skuruppu @codyoss