Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub: support clearing dead letter policies #1822

Closed
hongalex opened this issue Mar 12, 2020 · 0 comments
Closed

pubsub: support clearing dead letter policies #1822

hongalex opened this issue Mar 12, 2020 · 0 comments
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@hongalex
Copy link
Member

hongalex commented Mar 12, 2020

Client

PubSub

Code

sub.Update(ctx, pubsub.SubscriptionConfigToUpdate{
  DeadLetterPolicy: &pubsub.DeadLetterPolicy{},
}

Expected behavior

Since setting DeadLetterPolicy to nil is a no-op, the zero value of the struct should be used to clear the dead letter policy.

Actual behavior

An error is returned saying the name for DeadLetterPolicy.DeadLetterTopic is an invalid resource name.

@hongalex hongalex added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: pubsub Issues related to the Pub/Sub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Mar 12, 2020
@hongalex hongalex self-assigned this Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

1 participant