feat(storage): add ObjectHandle.Move method #11302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
tritone
changed the title
Tulsishah
reviewed
Dec 18, 2024
Tulsishah
reviewed
Dec 18, 2024
Tulsishah
reviewed
Dec 18, 2024
BrennaEpp
reviewed
Dec 18, 2024
| if err := applyCondsProto("MoveObjectDestination", defaultGen, params.dstConds, req); err != nil { | ||
| return nil, err | ||
| } | ||
| if err := applySourceCondsProto("MoveObjectSource", defaultGen, params.srcConds, req); err != nil { |
There was a problem hiding this comment.
Why is this set to defaultGen?
There was a problem hiding this comment.
Generation is not a field on the request. In general it doesn't look like you can specify a generation to move while leaving behind others at the source.
rainmark11
reviewed
Dec 18, 2024
BrennaEpp
approved these changes
Dec 19, 2024
tritone
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the new MoveObject API in both gRPC and JSON.