Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(internal/trace): remove previously deprecated OpenCensus support #11230

Merged
merged 3 commits into from
Dec 6, 2024
Merged

feat(internal/trace): remove previously deprecated OpenCensus support #11230

merged 3 commits into from
Dec 6, 2024

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Dec 5, 2024 •
edited
Loading

  • Remove support for GOOGLE_API_GO_EXPERIMENTAL_TELEMETRY_PLATFORM_TRACING
  • The following internal functions are now deprecated and will soon be
    removed::
    • SetOpenTelemetryTracingEnabledField
    • IsOpenCensusTracingEnabled
    • IsOpenTelemetryTracingEnabled

refs: #10287

@quartzmo quartzmo requested a review from a team as a code owner December 5, 2024 20:26
@quartzmo
feat(internal/trace): remove previously deprecated OpenCensus support
343bf2e 
* Remove support for GOOGLE_API_GO_EXPERIMENTAL_TELEMETRY_PLATFORM_TRACING
* The following internal functions are now deprecated and will soon be
  removed::
  * SetOpenTelemetryTracingEnabledField
  * IsOpenCensusTracingEnabled
  * IsOpenTelemetryTracingEnabled

refs: googleapis#10287
@quartzmo quartzmo force-pushed the internal-trace-opencensus-remove branch from 60ea03c to 343bf2e Compare December 5, 2024 20:29
@quartzmo quartzmo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 5, 2024
@quartzmo
Copy link
Member Author

quartzmo commented Dec 5, 2024

Do not merge pending cleanup of deprecated usages in client libraries.

quartzmo added a commit to quartzmo/google-cloud-go that referenced this pull request Dec 5, 2024
@quartzmo
chore(spanner): remove deprecated usages of internal/trace from tests
c20120f 
refs: googleapis#10287
refs: googleapis#11230
@quartzmo quartzmo mentioned this pull request Dec 5, 2024
Merged
quartzmo added a commit to quartzmo/google-cloud-go that referenced this pull request Dec 5, 2024
@quartzmo
chore(spanner): remove deprecated usages of internal/trace from tests
54760dc 
refs: googleapis#10287
refs: googleapis#11230
quartzmo added a commit that referenced this pull request Dec 6, 2024
@quartzmo
chore(spanner): remove deprecated usages of internal/trace from tests (…
7e680b9 
…#11233)

refs: #10287
refs: #11230
@quartzmo quartzmo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 6, 2024
shollyman
shollyman approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Farewell to thee, oh census libraryyyyyy...

@quartzmo quartzmo merged commit 40cf125 into googleapis:main Dec 6, 2024
9 checks passed
@quartzmo quartzmo deleted the internal-trace-opencensus-remove branch December 6, 2024 17:57
@release-please release-please bot mentioned this pull request Dec 6, 2024
Merged
quartzmo added a commit to quartzmo/google-api-go-client that referenced this pull request Dec 6, 2024
@quartzmo
feat(transport): remove deprecated EXPERIMENTAL OpenCensus trace cont…
bbe35ff 
…ext propagation

* See https://github.com/googleapis/google-cloud-go/blob/main/debug.md\#telemetry

refs: googleapis/google-cloud-go#10287
refs: googleapis/google-cloud-go#11230
@quartzmo quartzmo mentioned this pull request Dec 6, 2024
Merged
quartzmo added a commit to quartzmo/google-cloud-go that referenced this pull request Dec 6, 2024
@quartzmo
feat(transport): remove deprecated EXPERIMENTAL OpenCensus trace cont…
26f7564 
…ext propagation

* See https://github.com/googleapis/google-cloud-go/blob/main/debug.md\#telemetry

refs: googleapis#10287
refs: googleapis#11230
@quartzmo quartzmo mentioned this pull request Dec 6, 2024
Merged
quartzmo added a commit to googleapis/google-api-go-client that referenced this pull request Dec 6, 2024
@quartzmo
feat(transport): remove deprecated EXPERIMENTAL OpenCensus trace cont…
2b3363e 
…ext propagation (#2901)

* See https://github.com/googleapis/google-cloud-go/blob/main/debug.md\#telemetry

refs: googleapis/google-cloud-go#10287
refs: googleapis/google-cloud-go#11230
quartzmo added a commit that referenced this pull request Dec 6, 2024
@quartzmo
feat(transport): remove deprecated EXPERIMENTAL OpenCensus trace cont…
0d1ac87 
…ext propagation (#11239)

* See https://github.com/googleapis/google-cloud-go/blob/main/debug.md\#telemetry

refs: #10287
refs: #11230
codyoss added a commit to codyoss/google-cloud-go that referenced this pull request Dec 10, 2024
@codyoss
test(spanner): skip/remove oc span related tests
6b53433 
I removed the obvious open census tests that were failing in googleapis#11257.
Some others it was not clear to me if these functions should be
instrumented with OT or not, so I skipped them for now and will let
the spanner team decide what to do with those tests.

Related: googleapis#11230
@codyoss codyoss mentioned this pull request Dec 10, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 10, 2024
@codyoss
test(spanner): skip/remove oc span related tests (#11260)
fdbd33b 
I removed the obvious open census tests that were failing in #11257. Some others it was not clear to me if these functions should be instrumented with OT or not, so I skipped them for now and will let the spanner team decide what to do with those tests.

Related: #11230
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 16, 2024
@release-please
chore(main): release 0.117.0 (#11237)
47eee33 
🤖 I have created a release *beep* *boop*
---


## [0.117.0](https://togithub.com/googleapis/google-cloud-go/compare/v0.116.0...v0.117.0) (2024-12-16)


### Features

* **internal/trace:** Remove previously deprecated OpenCensus support ([#11230](https://togithub.com/googleapis/google-cloud-go/issues/11230)) ([40cf125](https://togithub.com/googleapis/google-cloud-go/commit/40cf1251c9d73be435585ce204a63588446c72b1)), refs [#10287](https://togithub.com/googleapis/google-cloud-go/issues/10287)
* **transport:** Remove deprecated EXPERIMENTAL OpenCensus trace context propagation ([#11239](https://togithub.com/googleapis/google-cloud-go/issues/11239)) ([0d1ac87](https://togithub.com/googleapis/google-cloud-go/commit/0d1ac87174ed8526ea47d71a80e641ffbd687a6c)), refs [#10287](https://togithub.com/googleapis/google-cloud-go/issues/10287) [#11230](https://togithub.com/googleapis/google-cloud-go/issues/11230)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quartzmo @shollyman @codyoss