feat(compute/metadata): add debug logging #11078
Merged
+338
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
added
the
do not merge
product-auto-label
bot
added
the
api: compute
|
Requires googleapis/gax-go#380 |
liggitt
reviewed
Nov 5, 2024
codyoss
force-pushed
the
computemetadata-logger
branch
2 times, most recently
from
4e2a467 to
93d2ad9
Compare
|
Requires #11079 |
codyoss
force-pushed
the
computemetadata-logger
branch
2 times, most recently
from
de98445 to
15ea68d
Compare
The compute/metadata module is used by too many other projects today so we should not force the dependeny on gax from this specific module. To tie into our client library logging we have the callers set up the integration. Because of this decision we have to vendor in some of the helper functions from gax into this project as well.
codyoss
force-pushed
the
computemetadata-logger
branch
from
15ea68d to
c273786
Compare
codyoss
removed
the
do not merge
quartzmo
requested changes
Dec 13, 2024
There was a problem hiding this comment.
I think we should copy/adapt https://github.com/googleapis/gax-go/blob/main/v2/internallog/internallog_test.go here as well, to cover log.go.
codyoss
added
the
automerge
codyoss
force-pushed
the
computemetadata-logger
branch
from
ec376a4 to
c82e30a
Compare
quartzmo
approved these changes
Dec 13, 2024
gcf-merge-on-green
bot
removed
the
automerge
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>compute: 1.31.0</summary> ## [1.31.0](https://togithub.com/googleapis/google-cloud-go/compare/compute/v1.30.0...compute/v1.31.0) (2024-12-13) ### Features * **compute:** Update Compute Engine API to revision 20241201 ([#971](https://togithub.com/googleapis/google-cloud-go/issues/971)) ([#11274](https://togithub.com/googleapis/google-cloud-go/issues/11274)) ([1f49a23](https://togithub.com/googleapis/google-cloud-go/commit/1f49a23270a3614ead812524d94a87c39b403e76)) </details> <details><summary>compute/metadata: 0.6.0</summary> ## [0.6.0](https://togithub.com/googleapis/google-cloud-go/compare/compute/metadata/v0.5.2...compute/metadata/v0.6.0) (2024-12-13) ### Features * **compute/metadata:** Add debug logging ([#11078](https://togithub.com/googleapis/google-cloud-go/issues/11078)) ([a816814](https://togithub.com/googleapis/google-cloud-go/commit/a81681463906e4473570a2f426eb0dc2de64e53f)) </details> <details><summary>config: 1.2.0</summary> ## [1.2.0](https://togithub.com/googleapis/google-cloud-go/compare/config/v1.1.2...config/v1.2.0) (2024-12-13) ### Features * **config:** Added annotations ([1f49a23](https://togithub.com/googleapis/google-cloud-go/commit/1f49a23270a3614ead812524d94a87c39b403e76)) ### Bug Fixes * **config:** Changed field behavior for an existing field `service_account` in message `.google.cloud.config.v1.Deployment` ([1f49a23](https://togithub.com/googleapis/google-cloud-go/commit/1f49a23270a3614ead812524d94a87c39b403e76)) * **config:** Changed field behavior for an existing field `service_account` in message `.google.cloud.config.v1.Preview` ([1f49a23](https://togithub.com/googleapis/google-cloud-go/commit/1f49a23270a3614ead812524d94a87c39b403e76)) ### Documentation * **config:** Service Account is a required field ([1f49a23](https://togithub.com/googleapis/google-cloud-go/commit/1f49a23270a3614ead812524d94a87c39b403e76)) </details> --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.