fix(auth): fallback cert lookups for missing files #11013
Merged
+4
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to googleapis#10696, we need to be careful of the case where we are trying to open files that may not exist. For instance trying to open something that does not exist in /dev/null/ is not a standard file does not exist err. Fixes: googleapis#10844
quartzmo
approved these changes
Oct 21, 2024
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.9.9](https://togithub.com/googleapis/google-cloud-go/compare/auth/v0.9.8...auth/v0.9.9) (2024-10-22) ### Bug Fixes * **auth:** Fallback cert lookups for missing files ([#11013](https://togithub.com/googleapis/google-cloud-go/issues/11013)) ([bd76695](https://togithub.com/googleapis/google-cloud-go/commit/bd766957ec238b7c40ddbabb369e612dc9b07313)), refs [#10844](https://togithub.com/googleapis/google-cloud-go/issues/10844) * **auth:** Replace MDS endpoint universe_domain with universe-domain ([#11000](https://togithub.com/googleapis/google-cloud-go/issues/11000)) ([6a1586f](https://togithub.com/googleapis/google-cloud-go/commit/6a1586f2ce9974684affaea84e7b629313b4d114)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #10696, we need to be careful of the case where we are trying to open files that may not exist. For instance trying to open something that does not exist in /dev/null/ is not a standard file does not exist err.
Fixes: #10844