feat(auth): add universe domain support to credentials/impersonate #10953
+206
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
quartzmo
commented
Oct 4, 2024
quartzmo
commented
- fix: return err if both Client and Credentials are set in CredentialsOptions
- fix: propagate Credentials universe domain in httptransport.AddAuthorizationMiddleware
* fix: return err if both Client and Credentials are set in CredentialsOptions * fix: propagate Credentials universe domain in httptransport.AddAuthorizationMiddleware
codyoss
reviewed
Oct 7, 2024
codyoss
reviewed
Oct 25, 2024
codyoss
requested changes
Oct 28, 2024
codyoss
approved these changes
Oct 28, 2024
quartzmo
added a commit
to quartzmo/google-cloud-go
that referenced
this pull request
Oct 29, 2024
quartzmo
added a commit
that referenced
this pull request
Oct 29, 2024
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
🤖 I have created a release *beep* *boop* --- ## [0.10.0](https://togithub.com/googleapis/google-cloud-go/compare/auth/v0.9.9...auth/v0.10.0) (2024-10-30) ### Features * **auth:** Add universe domain support to credentials/impersonate ([#10953](https://togithub.com/googleapis/google-cloud-go/issues/10953)) ([e06cb64](https://togithub.com/googleapis/google-cloud-go/commit/e06cb6499f7eda3aef08ab18ff197016f667684b)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.