perf(bigtable): Use RecvMsg instead of Recv #10674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
igorbernstein2
approved these changes
Aug 27, 2024
gkevinzheng
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadRows is streaming RPC. Currently, for each ReadRows a new message is allocated. This is causing high GCP bills and high memory usage.
google-cloud-go/bigtable/apiv2/bigtablepb/bigtable.pb.go
Lines 4050 to 4051 in 5b4b0f7
This PR changes this to use RecvMsg directly instead of Recv
pprof before:
pprof after (about ~13.25 % less memory usage):
RecvMsg uses proto.Unmarshal
Here, Merge is not set and thus unmarshal resets the message everytime before writing to it.
https://github.com/protocolbuffers/protobuf-go/blob/4fd828fdbf4719ded75c6f44681aea87a10968c2/proto/decode.go#L52-L59
https://github.com/protocolbuffers/protobuf-go/blob/4fd828fdbf4719ded75c6f44681aea87a10968c2/proto/decode.go#L89-L91
https://github.com/protocolbuffers/protobuf-go/blob/4fd828fdbf4719ded75c6f44681aea87a10968c2/proto/reset.go#L13-L16