Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigquery: ArrowIterator Next is not thread-safe and might be leaking goroutines #10672

Open
2 of 4 tasks
alvarowolfx opened this issue Aug 12, 2024 · 0 comments
Open
2 of 4 tasks
Assignees
Labels
api: bigquery Issues related to the BigQuery API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@alvarowolfx
Copy link
Contributor

alvarowolfx commented Aug 12, 2024

Per discussion with customer, we found points of issues:

  • ArrowIterator.Next is not Thread-safe
    • init call needs locks
    • first <-it.records call can be potentially removed
  • if multiple errors lock the err channel, context is not checked
  • consumeStream needs to check context done
  • double check that only one context is being used (it.ctx / it.session.ctx )
@alvarowolfx alvarowolfx added api: bigquery Issues related to the BigQuery API. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 12, 2024
@alvarowolfx alvarowolfx self-assigned this Aug 12, 2024
@alvarowolfx alvarowolfx changed the title bigquery: ArrowIterator Next is not thread-safe and might be leaking goroutines. bigquery: ArrowIterator Next is not thread-safe and might be leaking goroutines Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

No branches or pull requests

1 participant