From 0559e87ea11c4befc866a0f072acf68cd979b79a Mon Sep 17 00:00:00 2001 From: Chris Cotter Date: Wed, 22 Feb 2023 13:12:16 -0500 Subject: [PATCH] test(storage): skip bucket update tests for gRPC (#7476) Skipping these for now due to an API behavior change. Will unskip when b/270215524 is resolved. --- storage/integration_test.go | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/storage/integration_test.go b/storage/integration_test.go index 45c8414a4546..5b228d019f03 100644 --- a/storage/integration_test.go +++ b/storage/integration_test.go @@ -477,7 +477,7 @@ func TestIntegration_BucketCreateDelete(t *testing.T) { } func TestIntegration_BucketLifecycle(t *testing.T) { - ctx := skipJSONReads(context.Background(), "no reads in test") + ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test") multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) { h := testHelper{t} @@ -617,7 +617,7 @@ func TestIntegration_BucketUpdate(t *testing.T) { } func TestIntegration_BucketPolicyOnly(t *testing.T) { - ctx := skipJSONReads(context.Background(), "no reads in test") + ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test") multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) { h := testHelper{t} @@ -707,7 +707,7 @@ func TestIntegration_BucketPolicyOnly(t *testing.T) { } func TestIntegration_UniformBucketLevelAccess(t *testing.T) { - ctx := skipJSONReads(context.Background(), "no reads in test") + ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test") multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) { h := testHelper{t} bkt := client.Bucket(prefix + uidSpace.New()) @@ -790,7 +790,7 @@ func TestIntegration_UniformBucketLevelAccess(t *testing.T) { } func TestIntegration_PublicAccessPrevention(t *testing.T) { - ctx := skipJSONReads(context.Background(), "no reads in test") + ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test") multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) { h := testHelper{t} @@ -884,7 +884,7 @@ func TestIntegration_PublicAccessPrevention(t *testing.T) { } func TestIntegration_Autoclass(t *testing.T) { - ctx := skipJSONReads(context.Background(), "no reads in test") + ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test") multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) { h := testHelper{t} @@ -2157,7 +2157,7 @@ func TestIntegration_SignedURL_EmptyStringObjectName(t *testing.T) { } func TestIntegration_BucketACL(t *testing.T) { - ctx := skipJSONReads(context.Background(), "no reads in test") + ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test") multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) { h := testHelper{t} @@ -3358,7 +3358,7 @@ func TestIntegration_CancelWrite(t *testing.T) { } func TestIntegration_UpdateCORS(t *testing.T) { - ctx := skipJSONReads(context.Background(), "no reads in test") + ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test") multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) { initialSettings := []CORS{ { @@ -3429,7 +3429,7 @@ func TestIntegration_UpdateCORS(t *testing.T) { } func TestIntegration_UpdateDefaultEventBasedHold(t *testing.T) { - ctx := skipJSONReads(context.Background(), "no reads in test") + ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test") multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) { h := testHelper{t} @@ -3523,7 +3523,7 @@ func TestIntegration_UpdateTemporaryHold(t *testing.T) { } func TestIntegration_UpdateRetentionExpirationTime(t *testing.T) { - ctx := skipJSONReads(context.Background(), "no reads in test") + ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test") multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) { h := testHelper{t} @@ -3607,7 +3607,7 @@ func TestIntegration_CustomTime(t *testing.T) { } func TestIntegration_UpdateRetentionPolicy(t *testing.T) { - ctx := skipJSONReads(context.Background(), "no reads in test") + ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test") multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) { initial := &RetentionPolicy{RetentionPeriod: time.Minute} @@ -3664,7 +3664,7 @@ func TestIntegration_UpdateRetentionPolicy(t *testing.T) { } func TestIntegration_DeleteObjectInBucketWithRetentionPolicy(t *testing.T) { - ctx := skipJSONReads(context.Background(), "no reads in test") + ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test") multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) { h := testHelper{t} @@ -3698,7 +3698,7 @@ func TestIntegration_DeleteObjectInBucketWithRetentionPolicy(t *testing.T) { } func TestIntegration_LockBucket(t *testing.T) { - ctx := skipJSONReads(context.Background(), "no reads in test") + ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test") multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) { h := testHelper{t} @@ -3742,7 +3742,7 @@ func TestIntegration_LockBucket_MetagenerationRequired(t *testing.T) { } func TestIntegration_KMS(t *testing.T) { - multiTransportTest(context.Background(), t, func(t *testing.T, ctx context.Context, bucket, prefix string, client *Client) { + multiTransportTest(skipGRPC("b/270215524"), t, func(t *testing.T, ctx context.Context, bucket, prefix string, client *Client) { h := testHelper{t} keyRingName := os.Getenv("GCLOUD_TESTS_GOLANG_KEYRING") @@ -3835,7 +3835,7 @@ func TestIntegration_PredefinedACLs(t *testing.T) { userOwner := prefixRoleACL{prefix: "user", role: RoleOwner} authenticatedRead := entityRoleACL{entity: AllAuthenticatedUsers, role: RoleReader} - ctx := skipJSONReads(context.Background(), "no reads in test") + ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test") multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) { h := testHelper{t}