Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect dev vs non-dev environment for Google.Cloud.Diagnostic.* Libraries #829

Closed
iantalarico opened this issue Mar 1, 2017 · 3 comments
Closed

Detect dev vs non-dev environment for Google.Cloud.Diagnostic.* Libraries #829

iantalarico opened this issue Mar 1, 2017 · 3 comments
Assignees
@iantalarico
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@iantalarico
Copy link
Contributor

Detecting dev vs non dev environments will allow for turning on and off features based on the environment. This requires more investigation and thought about use cases.

cc @jskeet
@iantalarico iantalarico self-assigned this Mar 1, 2017
@iantalarico iantalarico mentioned this issue Mar 1, 2017
Merged
@Jetski5822
Copy link
Contributor

Injecting in IHostingEnvrionment and using IsDevelopment() could work for this. Whats the scenarios?

I did this in Orchard Core, but instead registered the middleware and services based on Environment

@iantalarico
Copy link
Contributor Author

We just want to make sure we don't report unneeded diagnostic info when we are in development mode.

@jskeet jskeet added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 21, 2017
@jskeet
Copy link
Collaborator

jskeet commented Dec 6, 2017

Closing for now having added this to the backlog

@jskeet jskeet closed this as completed Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iantalarico iantalarico

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jskeet @Jetski5822 @iantalarico