Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Diagnostics] RateLimiter not working properly when almost everything needs to be traced and there are many parallel requests. #2834

Closed
amanda-tarafa opened this issue Jan 25, 2019 · 0 comments · Fixed by #2835
Closed

[Diagnostics] RateLimiter not working properly when almost everything needs to be traced and there are many parallel requests. #2834

amanda-tarafa opened this issue Jan 25, 2019 · 0 comments · Fixed by #2835
Assignees
@amanda-tarafa
Labels
api: cloudtrace Issues related to the Cloud Trace API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@amanda-tarafa
Copy link
Contributor

I will shortly submit a PR with a fix and a test.

Bug found while solving #2791.
@amanda-tarafa amanda-tarafa added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: cloudtrace Issues related to the Cloud Trace API. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 25, 2019
@amanda-tarafa amanda-tarafa self-assigned this Jan 25, 2019
This was referenced Jan 25, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amanda-tarafa amanda-tarafa

Labels
api: cloudtrace Issues related to the Cloud Trace API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
1 participant
@amanda-tarafa