Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Timed and Sized buffer combination for the Google.Cloud.Diagnostics.* libraries #2163

Closed
iantalarico opened this issue May 22, 2018 · 1 comment
Closed

Create a Timed and Sized buffer combination for the Google.Cloud.Diagnostics.* libraries #2163

iantalarico opened this issue May 22, 2018 · 1 comment
Assignees
@amanda-tarafa
Labels
api: clouderrorreporting Issues related to the Error Reporting API. api: cloudtrace Issues related to the Cloud Trace API. api: logging Issues related to the Cloud Logging API. needs work This is a pull request that needs a little love. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@iantalarico
Copy link
Contributor

We should create a timed and sized buffer for the Google.Cloud.Diagnostics.* libraries. This would allow for a combination of the best of both. We will always flush after some time so entries aren't miss and won't ever hold on to too many entries waiting for a flush.
@iantalarico iantalarico added api: logging Issues related to the Cloud Logging API. api: cloudtrace Issues related to the Cloud Trace API. api: clouderrorreporting Issues related to the Error Reporting API. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 22, 2018
@jskeet jskeet added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label May 31, 2018
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Nov 18, 2018
@jskeet jskeet added needs work This is a pull request that needs a little love. and removed 🚨 This issue needs some love. labels Apr 24, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 24, 2019
@iantalarico iantalarico removed their assignment Jul 2, 2019
@jskeet jskeet removed the 🚨 This issue needs some love. label Jul 3, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jul 3, 2019
@jskeet jskeet removed 🚨 This issue needs some love. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 1, 2019
@amanda-tarafa amanda-tarafa added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Dec 16, 2019
@jskeet
Copy link
Collaborator

jskeet commented Mar 12, 2020

Closing for the moment as customers haven't mentioned a need for this.

@jskeet jskeet closed this as completed Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amanda-tarafa amanda-tarafa

Labels
api: clouderrorreporting Issues related to the Error Reporting API. api: cloudtrace Issues related to the Cloud Trace API. api: logging Issues related to the Cloud Logging API. needs work This is a pull request that needs a little love. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jskeet @JustinBeckwith @iantalarico @amanda-tarafa @yoshi-automation